Chapter 4

Which review comments are rules, and which are taste?

Lời rà nào là bắt buộc, lời nào chỉ là ý thích?

The chapter's question

Does my review comment help the recipient know what to do next?

Big idea

A good review comment states clearly what must be fixed and what is only a suggestion.

In this chapter

  1. Part 4.1

    Must-Fix Versus Suggestion

    Can the recipient tell which comments are mandatory?

  2. Part 4.2

    Asking Instead of Declaring

    Which questions open better discussion than a criticism?

  3. Part 4.3

    Specific Praise

    Do I point out what was done well?

  4. Part 4.4

    Talking Directly

    When should we talk instead of adding more comments?

The reading for this chapter is inside Conan School

This chapter has 4 readings, with case stories and exercises. Chapter 1 of A Day in the Life of a Code Reviewer is free to read right here.

Read in Conan School

Chapters of A Day in the Life of a Code Reviewer

  1. 1.Is code review really about catching bugs?
  2. 2.Why do bigger changes get approved faster?
  3. 3.The generated code looks clean, but is it right?
  4. 4.Which review comments are rules, and which are taste?
  5. 5.What does a change cost while it waits for review?